]> code.ossystems Code Review - openembedded-core.git/commit
wic: Make exec_cmd() error out instead of warn
authorTom Zanussi <tom.zanussi@linux.intel.com>
Thu, 31 Jul 2014 18:55:24 +0000 (13:55 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 11 Aug 2014 09:52:14 +0000 (10:52 +0100)
commita10bbd39eee29cc49d258bf08aaec279c3115c66
tree8b21d530659ab6672bab3a630c2a8b59d2836ef1
parent3ae32d0d6c7cf8294300f32d346da36748e05f3d
wic: Make exec_cmd() error out instead of warn

The reason exec_cmd() warns but doesn't error out (broken parted)
doesn't really make sense, since the parted invocations don't even use
exec_cmd().  It really should just fail since by not doing so it's
actually enabling invalid images in some cases.

Also, since the return code is now always zero, there's no point in
having a return code, so remove it.  This represents a change in the
API, so we also need to update all callers.

Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
scripts/lib/mic/kickstart/custom_commands/partition.py
scripts/lib/mic/plugins/source/bootimg-efi.py
scripts/lib/mic/plugins/source/bootimg-pcbios.py
scripts/lib/mic/utils/fs_related.py
scripts/lib/mic/utils/oe/misc.py
scripts/lib/mic/utils/partitionedfs.py