]> code.ossystems Code Review - openembedded-core.git/commit
runqemu: fix handling of SIGTERM and the problem of line wrapping
authorChen Qi <Qi.Chen@windriver.com>
Tue, 25 Sep 2018 07:08:25 +0000 (15:08 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 18 Oct 2018 10:08:46 +0000 (11:08 +0100)
commita2ee5c8a1ff449250e6f37fccf01b85a7361b24c
tree307c6a44638d168dc49b0161b525276ce25dcc2a
parentbc030c9f5af4af5a8bad48bc8beca9324a65d25b
runqemu: fix handling of SIGTERM and the problem of line wrapping

The current handling of SIGTERM is incorrect as the process pid returned
by Popen call with shell setting to True is actualy the shell instead of
the qemu process. So use shlex to split cmd so that we can avoid using
shell=True. This ensures the child process is the actual qemu process.

Also, as we install a SIGTERM handler, we need handle the situation of
qemu terminated by SIGTERM, otherwise we will get ERROR message in such
case.

Besides, we have a problem that after running qemu, the terminal's behavior
is incorrect regarding long lines or long commands. Long commands or long
outputs should appear in multiple lines, but they appear in the same line,
overriding previous output. Use `tput smam' to fix this problem.

(From OE-Core rev: e8acef383767cfd1ef0c3d3c45d9d6eb1c83b3e7)

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
scripts/runqemu