]> code.ossystems Code Review - openembedded-core.git/commit
opkg: Fix add-exclude.patch
authorPaul Barker <paul@paulbarker.me.uk>
Wed, 19 Feb 2014 15:15:17 +0000 (15:15 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 20 Feb 2014 14:28:05 +0000 (14:28 +0000)
commitc269cea3117d7fa120c02bdb47d1adf18a1bcba1
tree6f2675e68ee64e3d4261b5952232732dd006c3ff
parent1f8d944860cf1b1c3f4a6c48e4e1bdc9b09ede12
opkg: Fix add-exclude.patch

The case statement for ARGS_OPT_ADD_EXCLUDE added to the argument handling
switch statement in opkg was missing a "break;" at the end, so it was falling
through into the handler for ARGS_OPT_NOACTION. Thus when "--add-exclude" was
specified on the command line it was as if "--noaction" was also being
specified. This appears to be the root cause of YP bug 5311.

Tested using the case described by Alexandru Georgescu in YP bug 5311:

    MACHINE ??= "qemux86"
    IMAGE_INSTALL_append = " man"
    PACKAGE_EXCLUDE = "man"
    PACKAGE_CLASSES ?= "package_ipk"

Built image and boot tested on qemu, ensured that man was not installed but the
rest of the system was installed correctly.

Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
Cc: Mark Hatle <mark.hatle@windriver.com>
Cc: Saul Wold <saul.wold@intel.com>
Cc: Alexandru Georgescu <alexandru.c.georgescu@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/recipes-devtools/opkg/opkg/add-exclude.patch