]> code.ossystems Code Review - openembedded-core.git/commit
rng-tools: Fix crazy defaults
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 3 Nov 2017 16:17:01 +0000 (16:17 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 4 Dec 2017 17:14:17 +0000 (17:14 +0000)
commitd177516d846ec4bed483d7e9d80775bb341c869e
treee98d8b04fac8df95ec6d14271e93207f3ee7ee7c
parentbfacf88f15a27db579d8790d92f8497d832961f8
rng-tools: Fix crazy defaults

Feeding the output of /dev/urandom into /dev/random is pretty much insane
and not something we should encourage.

I can't really imagine a scenario where this would be a sensible idea since
/dev/urandom if effectively derived from /dev/random.

This changes the tool to default to /dev/hwrng which makes much more sense,
feeding hardware entropy into the random pool. In the QEMU case, this will
feed entropy from the host into the guests which is also what we want.

Yes, this change will cause rngd not to start if /dev/hwrng isn't present,
but it isn't needed if that isn't so I don't see this as a bad thing.

(https://wiki.archlinux.org/index.php/Rng-tools has a section in red which
agrees with the above, "this is a really bad idea, since you are simple
filling the kernel entropy pool with entropy coming from the kernel itself!")

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit f1dc9ac46710814c27cae2d22e79c84a9522993a)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-support/rng-tools/rng-tools/default