]> code.ossystems Code Review - openembedded-core.git/commit
uboot-sign: Fix build when UBOOT_DTB_BINARY is empty
authorAlex Kiernan <alex.kiernan@gmail.com>
Wed, 17 Apr 2019 18:31:16 +0000 (18:31 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 2 May 2019 21:20:24 +0000 (22:20 +0100)
commite79f0db0745625b35dd83483747e486d08eebfde
treed0055a716b435afc1182aa834d697a80aca31a89
parente329f1a9ad7e68575912345ec7c18c12f5971998
uboot-sign: Fix build when UBOOT_DTB_BINARY is empty

When UBOOT_DTB_BINARY is empty and because the code now changes
directory into ${B}, the test for the existence becomes `[ -f ]` which
succeeds and subsequently the install fails.

Reorder the code so it's clear that UBOOT_DTB_BINARY empty is an
expected configuration and then quote UBOOT_DTB_BINARY everywhere so
no one trips over this again.

Fixes: bacb59079eb6 ("uboot-sign: add support for different u-boot configurations")
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/uboot-sign.bbclass