]> code.ossystems Code Review - openembedded-core.git/commit
meta: replace os.popen with subprocess.Popen
authorRobert Yang <liezhi.yang@windriver.com>
Tue, 29 May 2012 14:53:08 +0000 (22:53 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 30 May 2012 09:58:10 +0000 (10:58 +0100)
commite83d8e58a6b107eea87df0ec233a1bc932b2c6ea
tree7373c71af06a1cc504ee251615c80ae3c07e6347
parent57f843146ed62c04c23bc380dc8cb38aba264f1c
meta: replace os.popen with subprocess.Popen

Replace os.popen with subprocess.Popen since the older function would
fail (more or less) silently if the executed program cannot be found

There are both bb.process.run() and bb.process.Popen() which wraps the
subprocess module, use it for simplifying the code.

Note: We don't need the "2>/dev/null" or "2>&1" since bb.process.run()
can handle it, it will raise exception when error occurs, we should
handle the exception ourselves if we want to ignore the error.

More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements

[YOCTO #2454]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/debian.bbclass
meta/classes/distrodata.bbclass
meta/classes/icecc.bbclass
meta/classes/insane.bbclass
meta/classes/kernel.bbclass
meta/classes/metadata_scm.bbclass
meta/classes/package.bbclass