]> code.ossystems Code Review - openembedded-core.git/commit
valgrind: drd: fix pthread intercept test failures
authorStacy Gaikovaia <Stacy.Gaikovaia@windriver.com>
Tue, 13 Oct 2020 14:44:26 +0000 (10:44 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 26 Oct 2020 13:45:45 +0000 (13:45 +0000)
commite8f265e957e187b4f84f566aaeec8f514e3044d6
treeccbb05adba6d149daf1e5ad0fd6f91d46a461f63
parent59aac6e134289d657d80bfb1d6f25b388d539818
valgrind: drd: fix pthread intercept test failures

After glibc uprev 2.31 -> 2.32, the following drd ptests
fail with the error "condition variable has not been initialized".

drd/tests/annotate_hb_err
drd/tests/annotate_sem
drd/tests/annotate_rwlock
drd/tests/annotate_order_2
drd/tests/annotate_smart_pointer
drd/tests/annotate_spinlock
drd/tests/monitor_example
drd/tests/pth_cond_race
drd/tests/pth_inconsistent_cond_wait

In glibc 2.32, the POSIX thread functions are in both
libc and libpthread, causing valgrind to misinterpert
test behaviour. This patch tells valgrind to intercept
both the libc and the libpthread functions, resolving
these ptest failures.

Here are the latest test results on qemux86-64:
=== Test Summary ===
TOTAL: 728
PASSED: 688
FAILED: 1
SKIPPED: 39

The failed test is in helgrind:
FAIL: helgrind/tests/pth_destroy_cond

Patch can be removed once we uprev valgrind.
See valgrind commit 15330adf7c2471fbaa6a0818db07078d81dbff97.

Signed-off-by: Stacy Gaikovaia <Stacy.Gaikovaia@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/valgrind/valgrind/0001-drd-Port-to-Fedora-33.patch [new file with mode: 0644]
meta/recipes-devtools/valgrind/valgrind_3.16.1.bb