]> code.ossystems Code Review - openembedded-core.git/commit
lib/oe/qa,insane: Move extra error handling functions to library
authorMike Crowe <mac@mcrowe.com>
Fri, 15 Oct 2021 14:39:53 +0000 (15:39 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 17 Oct 2021 10:55:21 +0000 (11:55 +0100)
commitf0ad152ef4cc15c042bc9eeefb6af096d054b220
tree1e645aea15554c8205bb720433e32407a4a2a3fd
parent05c0e34122ea1272704ddb90657e592f15f5c557
lib/oe/qa,insane: Move extra error handling functions to library

Extract package_qa_write_error, package_qa_handle_error and
package_qa_add_message functions from insane.bbclass to lib/oe/qa.py and
drop the package_qa_ prefixes.

Update various bbclasses to use the new functions. No import is required
since base.bbclass puts oe.qa in OE_IMPORTS.

Stop requiring callers to manually track whether a fatal error has been
encountered via a "sane" flag. Instead replace the QA_SANE variable with
QA_ERRORS_FOUND and call oe.qa.exit_if_errors or
oe.qa.exit_with_message_if_errors at the end of each task.

Inspired by discussion resulting from
https://lists.openembedded.org/g/openembedded-core/message/156793 and
https://lists.openembedded.org/g/openembedded-core/message/156900

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/buildhistory.bbclass
meta/classes/insane.bbclass
meta/classes/multilib.bbclass
meta/classes/package.bbclass
meta/classes/ptest.bbclass
meta/lib/oe/qa.py