]> code.ossystems Code Review - openembedded-core.git/commit
glibc: add ld.so locks in _libc_fork
authorZhixiong Chi <zhixiong.chi@windriver.com>
Tue, 5 Sep 2017 04:29:44 +0000 (12:29 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 11 Sep 2017 16:30:10 +0000 (17:30 +0100)
commitf2e586ebf59a9b7d5b216fc92aeb892069a4b0c1
tree8c65e2c9dc2261817b71788486c90ac031ff2851
parent11350a67ba137f560d04aa643ff500a7ff112c73
glibc: add ld.so locks in _libc_fork

The patch in this Bugzilla entry was requested by a customer:
  https://sourceware.org/bugzilla/show_bug.cgi?id=4578
  https://www.sourceware.org/bugzilla/show_bug.cgi?id=19282

If a thread happens to hold dl_load_lock and have r_state set to RT_ADD or
RT_DELETE at the time another thread calls fork(), then the child exit code
from fork (in nptl/sysdeps/unix/sysv/linux/fork.c in our case) re-initializes
dl_load_lock but does not restore r_state to RT_CONSISTENT. If the child
subsequently requires ld.so functionality before calling exec(), then the
assertion will fire.

The patch acquires dl_load_lock on entry to fork() and releases it on exit
from the parent path.  The child path is initialized as currently done.
This is essentially pthreads_atfork, but forced to be first because the
acquisition of dl_load_lock must happen before malloc_atfork is active
to avoid a deadlock.

The __libc_fork() code reset dl_load_lock, but it also needed to reset
dl_load_write_lock.

Signed-off-by: Zhixiong Chi <zhixiong.chi@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-core/glibc/glibc/0027-glibc-reset-dl-load-write-lock-after-forking.patch [new file with mode: 0644]
meta/recipes-core/glibc/glibc/0028-Bug-4578-add-ld.so-lock-while-fork.patch [new file with mode: 0644]
meta/recipes-core/glibc/glibc_2.26.bb