]> code.ossystems Code Review - openembedded-core.git/commit
openssl: force soft link to avoid rare race
authorRandy MacLeod <Randy.MacLeod@windriver.com>
Mon, 16 Oct 2017 15:00:45 +0000 (11:00 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 4 Dec 2017 17:14:20 +0000 (17:14 +0000)
commitf6be81b1dddc7adc2e97fefb2bd6c296d4dce8c6
tree9b9d1588300784a2fe0dfa3809e8b88d0ab95886
parent511db7c256dbb3f8ba95eabd025d427384d4a1cb
openssl: force soft link to avoid rare race

This patch works around a rare parallel build race condition using
the force option when soft linking.

The error seen is:

ln: failed to create symbolic link 'libssl.so': File exists
make[4]: *** [Makefile.shared:171: link_a.gnu] Error 1
make[4]: Leaving directory
'/.../build/tmp-glibc/work/x86_64-linux/openssl-native/1.0.2k-r0/openssl-1.0.2k'

Just add the -f flag to the platform independent soft link code to
avoid the collision.  This is reasonable since this Makefile removes
the link target before creating a new soft link. The Makefile was
written this way to support platforms that don't allow forcing a
softlink to overwrite an existing link. Only builds on Linux are
supported so that's not a requirement for oe-core recipes.

The openssl team is rewriting their build files so it's not appropriate
for openssl upstream and fixing the root cause of the race condition
was also not pursued.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
(cherry picked from commit c60288aba70635238094c6b813228b31e0715db9)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-connectivity/openssl/openssl-1.0.2l/0001-openssl-force-soft-link-to-avoid-rare-race.patch [new file with mode: 0644]
meta/recipes-connectivity/openssl/openssl_1.0.2l.bb