]> code.ossystems Code Review - openembedded-core.git/commit
bash: fix mkbuiltins build failure
authorChristopher Larson <chris_larson@mentor.com>
Wed, 14 Nov 2012 14:55:09 +0000 (07:55 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 14 Nov 2012 15:57:13 +0000 (15:57 +0000)
commitf7a25dd72d1d463eb72d48c6f9dd968d376496c0
tree08c8077da5aba3ace4ab06ef4ad5a73463227d20
parent172a74c540378149eec493c37c030e9f42f9603d
bash: fix mkbuiltins build failure

On hosts with FORTIFY_SOURCES, stringize support is required, as it's used by
the macros to wrap functions (e.g. read and open in unistd.h). Those wrappers
use the STRING() macro from unistd.h. A header in the bash sources overrides
the unistd.h macro to 'x' when HAVE_STRINGIZE is not defined, causing the
wrappers to generate calls to 'xread' and 'xopen', which do not exist,
resulting in a failure to link.

Assume we have stringize support when cross-compiling, which works around the
issue.

It may be best for upstream to either give up on supporting compilers without
stringize support, or to not define STRING() at all when FORTIFY_SOURCES is
defined, letting the unistd.h one be used, instead.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-extended/bash/bash-4.2/mkbuiltins_have_stringize.patch [new file with mode: 0644]
meta/recipes-extended/bash/bash_4.2.bb