]> code.ossystems Code Review - openembedded-core.git/commit
insane.bbclass: make the checking stricter for unsafe references in scripts
authorChen Qi <qi.chen@windriver.com>
Fri, 19 Feb 2016 02:38:39 +0000 (10:38 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 4 Mar 2016 17:10:59 +0000 (17:10 +0000)
commitf818f7359c1a5db2c5c041c42eecb9f0434d9800
treebe0e81c73349e2ed40bcf8733849822ce480eb11
parent092984669d8590627cfb188a0aa00244e22c4671
insane.bbclass: make the checking stricter for unsafe references in scripts

Previously, the checking for unsafe references is not strict enough. It
only checks whether '/usr/' is in the script. As a result, any script
containing statements like below will match this check.

   PATH="/bin:/sbin:/usr/bin:/usr/sbin"

However, as we can see, this is actually not an unsafe reference. What
we really want to check is something like '/usr/bin/tail', so we should
make the checking stricter.

This patch solves the QA warning in gzip and nfs-utils.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/insane.bbclass