]> code.ossystems Code Review - openembedded-core.git/commit
base-files: add some safety checks in profile
authorDiego Rondini <diego.ml@zoho.com>
Fri, 29 Apr 2016 10:24:09 +0000 (12:24 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 29 Jun 2016 18:34:40 +0000 (19:34 +0100)
commitfde37b91284953cedc50bc32d22aac65a65afde1
tree3f6301690c20e0ea8df46ca13b730db26abec3de
parentbc657f9c310a247047d52253f7b62061be5d8404
base-files: add some safety checks in profile

Add some safety checks when sourcing files in /etc/profile.d/, in particular:
- source only *.sh files, not every file. This is the practice in use in both
  Fedora and Debian/Ubuntu (see
  https://help.ubuntu.com/community/EnvironmentVariables#A.2Fetc.2Fprofile.d.2F.2A.sh);
- check the input is actually a file and is readable. This check is especially
  important if profile.d is empty, as "*.sh" will get expanded only if
  profile.d is not empty. Previously if profile.d was present but empty,
  "/etc/profile.d/*" was sourced causing errors on login and breaking stuff, for
  example X startup.

(From OE-Core rev: 8961bc4b71723477a3b4a837a1d9c25c1b860b9e)

Signed-off-by: Diego Rondini <diego.ml@zoho.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster@mvista.com>
meta/recipes-core/base-files/base-files/profile