]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/targetcontrol.py: fix qemuparams not work in runqemu with launch_cmd
authorHongxu Jia <hongxu.jia@windriver.com>
Mon, 13 May 2019 15:12:46 +0000 (11:12 -0400)
committerArmin Kuster <akuster808@gmail.com>
Sat, 1 Jun 2019 21:48:32 +0000 (14:48 -0700)
As runqemu with launch_cmd means directly run the command, don't need set
rootfs or env vars.

Since commit [a847dd7202 runqemu: Let qemuparams override default settings]
applied in oe-core, if launch_cmd contains "qemuparams='***'", it does not
work, which is overridden by latter qemuparams="-serial tcp:127.0.0.1" in
QemuRunner.launch();

So we set qemuparams as a parameter in runqemu, the fix makes it work

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/lib/oeqa/targetcontrol.py

index 1868ad32066e53f200930c57ec9213b4bfa19aa7..b98b183504e431ced63262bd4c01f9ccad11a495 100644 (file)
@@ -159,7 +159,7 @@ class QemuTarget(BaseTarget):
 
     def start(self, params=None, ssh=True, extra_bootparams='', runqemuparams='', launch_cmd='', discard_writes=True):
         if launch_cmd:
-            start = self.runner.launch(get_ip=ssh, launch_cmd=launch_cmd)
+            start = self.runner.launch(get_ip=ssh, launch_cmd=launch_cmd, qemuparams=params)
         else:
             start = self.runner.start(params, get_ip=ssh, extra_bootparams=extra_bootparams, runqemuparams=runqemuparams, discard_writes=discard_writes)