]> code.ossystems Code Review - openembedded-core.git/commitdiff
e2fsprogs: Fix a ptest permissions determinism issue
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 21 Nov 2020 14:47:54 +0000 (14:47 +0000)
committerSteve Sakoman <steve@sakoman.com>
Mon, 30 Nov 2020 22:05:57 +0000 (12:05 -1000)
When comparing builds built with different host umasks, this file jumped out.
The umask from do_compile was influencing ${D} and as cp was used to add the
file it wasn't deterministic. Fix the file mode to ensure determinism.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 37f37f4a52de3711973b372160f23672b61ff6ad)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.45.4.bb

index 4f7cafeac979be8e58304fc0d578fe9aa6320942..439928e43301195a28544a713e27b14bf5950692 100644 (file)
@@ -128,6 +128,8 @@ do_compile_ptest() {
 }
 
 do_install_ptest() {
+       # This file's permissions depends on the host umask so be deterministic
+       chmod 0644 ${B}/tests/test_data.tmp
        cp -R --no-dereference --preserve=mode,links -v ${B}/tests ${D}${PTEST_PATH}/test
        cp -R --no-dereference --preserve=mode,links -v ${S}/tests/* ${D}${PTEST_PATH}/test
        sed -e 's!../e2fsck/e2fsck!e2fsck!g' \