]> code.ossystems Code Review - openembedded-core.git/commitdiff
kernel-yocto: propagate in tree defconfigs to WORKDIR
authorBruce Ashfield <bruce.ashfield@windriver.com>
Fri, 8 May 2015 03:36:15 +0000 (23:36 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 28 Jun 2015 08:41:53 +0000 (09:41 +0100)
As reported by Steffen Pankratz <Steffen.Pankratz@elektrobit.com>, the
previous logic of KBUILD_DEFCONFIG processing would not propagate an in
tree defcofig to WORKDIR if one was not already present.

We fix the propagation by copying the in tee config if a defconfig is
not already in WORKDIR.

Additionally we only warn (versus copying) if an in tree configuration
is specified, is different than the WORKDIR version and isn't copied.

(From OE-Core rev: 58cc903a5156063b24e48011438a709cb6e09f54)

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/kernel-yocto.bbclass

index 0dd5b4851361e821b50003370d7b637a7f387f55..88588d7cacc93008c5cc75bea27a37689fe475bd 100644 (file)
@@ -97,14 +97,15 @@ do_kernel_metadata() {
        if [ -n "${KBUILD_DEFCONFIG}" ]; then
                if [ -f "${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG}" ]; then
                        if [ -f "${WORKDIR}/defconfig" ]; then
-                               # If the two defconfigs are the same, leave the existing one in place
+                               # If the two defconfig's are different, warn that we didn't overwrite the
+                               # one already placed in WORKDIR by the fetcher.
                                cmp "${WORKDIR}/defconfig" "${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG}"
                                if [ $? -ne 0 ]; then
-                                       bbnote "defconfig detected in WORKDIR. ${KBUILD_DEFCONFIG} skipped"
-                               else
-                                       cp -f ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG} ${WORKDIR}/defconfig
-                                       sccs="${WORKDIR}/defconfig"
+                                       bbwarn "defconfig detected in WORKDIR. ${KBUILD_DEFCONFIG} skipped"
                                fi
+                       else
+                               cp -f ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG} ${WORKDIR}/defconfig
+                               sccs="${WORKDIR}/defconfig"
                        fi
                else
                        bbfatal "A KBUILD_DECONFIG '${KBUILD_DEFCONFIG}' was specified, but not present in the source tree"