]> code.ossystems Code Review - openembedded-core.git/commitdiff
qemuwrapper: use fallback in case the ELF binary is wrong
authorLaurentiu Palcu <laurentiu.palcu@intel.com>
Fri, 26 Apr 2013 08:03:58 +0000 (11:03 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 29 Apr 2013 13:43:53 +0000 (14:43 +0100)
This wrapper script is called mainly from intercept hooks and allarch
packages postinstalls. When multilib is used, the qemuwrapper script
points to the binary that matches the MACHINE architecture.

For example: if MACHINE=qemux86_64 and we activate multilib, then the
postinstalls for lib32 packages would call qemu-x86_64 with 32 bit
binaries and they would certainly fail.

This patch adds just a fallback method if the exit code of the previous
qemu call corresponds to "Invalid ELF image for this architecture"
error. This will allow us to have all postinstalls run on host.

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb

index 41617a6b756ad103006f404c7a8e1240cbe4e306..18f1892884389fe28b882cc6d67c1ad05757a662 100644 (file)
@@ -9,7 +9,33 @@ do_install () {
        install -d ${D}${bindir_crossscripts}/
 
        echo "#!/bin/sh" > ${D}${bindir_crossscripts}/qemuwrapper
-       echo exec env ${@qemu_target_binary(d)} \"\$@\" >> ${D}${bindir_crossscripts}/qemuwrapper
+       qemu_binary=${@qemu_target_binary(d)}
+       echo "$qemu_binary \"\$@\"" >> ${D}${bindir_crossscripts}/qemuwrapper
+       fallback_qemu_bin=
+       case $qemu_binary in
+               "qemu-i386")
+                       fallback_qemu_bin=qemu-x86_64
+                       ;;
+               "qemu-x86_64")
+                       fallback_qemu_bin=qemu-i386
+                       ;;
+               *)
+                       ;;
+       esac
+
+       if [ -n "$fallback_qemu_bin" ]; then
+
+               cat >> ${D}${bindir_crossscripts}/qemuwrapper << EOF
+rc=\$?
+if [ \$rc = 255 ]; then
+       $fallback_qemu_bin "\$@"
+       rc=\$?
+fi
+exit \$rc
+EOF
+
+       fi
+
        chmod +x ${D}${bindir_crossscripts}/qemuwrapper
 }