]> code.ossystems Code Review - openembedded-core.git/commitdiff
image.bbclass: fix incomplete .rootfs customization
authorPatrick Ohly <patrick.ohly@intel.com>
Mon, 7 Mar 2016 21:13:48 +0000 (22:13 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 7 Mar 2016 22:01:16 +0000 (22:01 +0000)
The patch for making the .rootfs configurable was incomplete: in the
python create_symlinks() method the new variable must be expanded
explicitly.

Not doing so broke the symlink creation and that led to hard build
failures in image types depending on the boot-directdisk.bbclass (like
qcow2) because the build_boot_dd() method relied on the symlink.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image.bbclass

index 081a0b32c62f3563a4f31ff3111cf79a723fdab2..8b6c30bce8daa06a3e3e4697c2d3984930ac7ada 100644 (file)
@@ -474,7 +474,7 @@ python create_symlinks() {
     manifest_name = d.getVar('IMAGE_MANIFEST', True)
     taskname = d.getVar("BB_CURRENTTASK", True)
     subimages = (d.getVarFlag("do_" + taskname, 'subimages', False) or "").split()
-    imgsuffix = d.getVarFlag("do_" + taskname, 'imgsuffix', True) or "${IMAGE_NAME_SUFFIX}."
+    imgsuffix = d.getVarFlag("do_" + taskname, 'imgsuffix', True) or d.expand("${IMAGE_NAME_SUFFIX}.")
     os.chdir(deploy_dir)
 
     if not link_name: