]> code.ossystems Code Review - openembedded-core.git/commitdiff
oe-selftest: devtool: fix error message in _test_recipe_contents()
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Mon, 31 Oct 2016 03:59:48 +0000 (16:59 +1300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 7 Nov 2016 11:04:17 +0000 (11:04 +0000)
If a variable is being set in the recipe when we've explicitly passed
None as the value to _test_recipe_contents() indicating that it
shouldn't be set at all, then we should be printing out the variable
name in the assertion message but it seems like I forgot to do a
substitution. Also include the value for informational purposes.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/lib/oeqa/selftest/devtool.py

index 713f2c5d63e15aa3fc59e3f14ca3b12288857265..71d205c73f205d7f4fae65eaa61a7d259d4dd84e 100644 (file)
@@ -44,7 +44,7 @@ class DevtoolBase(oeSelfTest):
                 if var and var in checkvars:
                     needvalue = checkvars.pop(var)
                     if needvalue is None:
-                        self.fail('Variable %s should not appear in recipe')
+                        self.fail('Variable %s should not appear in recipe, but value is being set to "%s"' % (var, value))
                     if isinstance(needvalue, set):
                         if var == 'LICENSE':
                             value = set(value.split(' & '))