]> code.ossystems Code Review - openembedded-core.git/commitdiff
rpm: brace expansion is a bashism
authorRoss Burton <ross.burton@intel.com>
Wed, 6 Apr 2016 12:20:29 +0000 (13:20 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 8 Apr 2016 07:05:12 +0000 (08:05 +0100)
The constuct rm *.{a,la} is a bashism and as tasks are run under /bin/sh this
may not work as expected.  Expand the {a,la} to two separate calls, and remove
the architecture-specific macro deletion as they are not installed in the first
place anymore.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/rpm/rpm_5.4+cvs.bb
meta/recipes-devtools/rpm/rpm_5.4.16.bb

index bacdef5242b2dd025df588a90abb7cf7c6c5e5d7..c6c21b86aa367c8df0bbf0490ab2404e9ccc61c5 100644 (file)
@@ -568,16 +568,15 @@ do_install_append() {
        rm -f ${D}/${mandir}/man1/lz*.1
        rm -f ${D}/${libdir}/pkgconfig/liblzma*
 
-       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/*.{a,la}
-       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/rpm/*.{a,la}
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/*.a
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/*.la
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/rpm/*.a
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/rpm/*.la
 
        #find ${D}/${libdir}/perl5 -type f -a \( -name perllocal.pod -o -name .packlist \
        #       -o \( -name '*.bs' -a -empty \) \) -exec rm -f {} ';'
        #find ${D}/${libdir}/perl5 -type d -depth -exec rmdir {} 2>/dev/null ';'
 
-       # We don't want the default macro set
-       rm -rf ${D}/${libdir}/rpm/{i[3456]86*,athlon*,pentium*,x86_64*,alpha*,sparc*,ia64*,ppc*,s390*,armv[34][lb]*,armv[345]*,mips*,noarch*}
-
        rm -f ${D}/${libdir}/rpm/dbconvert.sh
 
        rm -f ${D}/${libdir}/rpm/libsqldb.*
index 7621f8ffaab2944587f901cb5de6cab982339e3d..d42724c212549365eda56d763c65fe4cdc8988fc 100644 (file)
@@ -576,16 +576,15 @@ do_install_append() {
        rm -f ${D}/${mandir}/man1/lz*.1
        rm -f ${D}/${libdir}/pkgconfig/liblzma*
 
-       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/*.{a,la}
-       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/rpm/*.{a,la}
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/*.a
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/*.la
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/rpm/*.a
+       rm -f ${D}/${libdir}/python%{with_python_version}/site-packages/rpm/*.la
 
        #find ${D}/${libdir}/perl5 -type f -a \( -name perllocal.pod -o -name .packlist \
        #       -o \( -name '*.bs' -a -empty \) \) -exec rm -f {} ';'
        #find ${D}/${libdir}/perl5 -type d -depth -exec rmdir {} 2>/dev/null ';'
 
-       # We don't want the default macro set
-       rm -rf ${D}/${libdir}/rpm/{i[3456]86*,athlon*,pentium*,x86_64*,alpha*,sparc*,ia64*,ppc*,s390*,armv[34][lb]*,armv[345]*,mips*,noarch*}
-
        rm -f ${D}/${libdir}/rpm/dbconvert.sh
 
        rm -f ${D}/${libdir}/rpm/libsqldb.*