]> code.ossystems Code Review - openembedded-core.git/commitdiff
oe_syslog.py: fix settings in OEHasPackage decorator
authorChen Qi <Qi.Chen@windriver.com>
Tue, 31 Jul 2018 01:25:01 +0000 (09:25 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 31 Jul 2018 21:42:03 +0000 (22:42 +0100)
1. For test_syslog_running, we should not restrict it to run for
   only busybox-syslog and sysklogd. So extend it to all syslog
   providers in oe-core and meta-openembedded.

2. For test_syslog_startup_config, fix to make it depend on the
   existence of busybox-syslog. The previous condition "!sysklogd
   && busybox" is incorrect, because busybox may be compiled without
   syslog support, and sysklogd and busybox-syslog conflict with
   each other.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
meta/lib/oeqa/runtime/cases/oe_syslog.py

index 005b6978d9d74ede0071c832ead1a65c541dc19f..935f10f0f3d28c03bc612cdc2c1481e21bccc050 100644 (file)
@@ -8,7 +8,7 @@ class SyslogTest(OERuntimeTestCase):
 
     @OETestID(201)
     @OETestDepends(['ssh.SSHTest.test_ssh'])
-    @OEHasPackage(["busybox-syslog", "sysklogd"])
+    @OEHasPackage(["busybox-syslog", "sysklogd", "rsyslog", "syslog-ng"])
     def test_syslog_running(self):
         cmd = '%s  | grep -i [s]yslogd' % self.tc.target_cmds['ps']
         status, output = self.target.run(cmd)
@@ -45,7 +45,7 @@ class SyslogTestConfig(OERuntimeTestCase):
 
     @OETestID(202)
     @OETestDepends(['oe_syslog.SyslogTestConfig.test_syslog_logger'])
-    @OEHasPackage(["!sysklogd", "busybox"])
+    @OEHasPackage(["busybox-syslog"])
     @skipIfDataVar('VIRTUAL-RUNTIME_init_manager', 'systemd',
                    'Not appropiate for systemd image')
     def test_syslog_startup_config(self):