]> code.ossystems Code Review - openembedded-core.git/commitdiff
rootfs-postcommands.bbclass: improve binary reproducibility
authorJuro Bystricky <juro.bystricky@intel.com>
Fri, 13 Apr 2018 22:47:44 +0000 (15:47 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 18 Apr 2018 17:48:20 +0000 (18:48 +0100)
Conditionally support binary reproducibility of rootfs images.
If REPRODUCIBLE_TIMESTAMP_ROOTFS is specified then:

1. set /etc/timestamp to a reproducible value
2. set /etc/version to a reproducible value
3. set /etc/gconf: set mtime in all %gconf.xml to reproducible values

The reproducible value is taken from the variable REPRODUCIBLE_TIMESTAMP_ROOTFS.

[YOCTO #11176]
[YOCTO #12422]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/rootfs-postcommands.bbclass

index a4e627fef842ea7d0600eade007952882acbf32b..552220953494a843da1c85ee6ad3ad23487b8655 100644 (file)
@@ -56,6 +56,7 @@ ROOTFS_POSTPROCESS_COMMAND_append_qemuall = "${SSH_DISABLE_DNS_LOOKUP}"
 SORT_PASSWD_POSTPROCESS_COMMAND ??= " sort_passwd; "
 python () {
     d.appendVar('ROOTFS_POSTPROCESS_COMMAND', '${SORT_PASSWD_POSTPROCESS_COMMAND}')
+    d.appendVar('ROOTFS_POSTPROCESS_COMMAND', 'rootfs_reproducible;')
 }
 
 systemd_create_users () {
@@ -256,10 +257,17 @@ python write_image_manifest () {
         os.symlink(os.path.basename(manifest_name), manifest_link)
 }
 
-# Can be use to create /etc/timestamp during image construction to give a reasonably
+# Can be used to create /etc/timestamp during image construction to give a reasonably
 # sane default time setting
 rootfs_update_timestamp () {
-       date -u +%4Y%2m%2d%2H%2M%2S >${IMAGE_ROOTFS}/etc/timestamp
+       if [ "${REPRODUCIBLE_TIMESTAMP_ROOTFS}" != "" ]; then
+               # Convert UTC into %4Y%2m%2d%2H%2M%2S
+               sformatted=`date -u -d @${REPRODUCIBLE_TIMESTAMP_ROOTFS} +%4Y%2m%2d%2H%2M%2S`
+       else
+               sformatted=`date -u +%4Y%2m%2d%2H%2M%2S`
+       fi
+       echo $sformatted > ${IMAGE_ROOTFS}/etc/timestamp
+       bbnote "rootfs_update_timestamp: set /etc/timestamp to $sformatted"
 }
 
 # Prevent X from being started
@@ -328,3 +336,16 @@ python rootfs_log_check_recommends() {
             if 'unsatisfied recommendation for' in line:
                 bb.warn('[log_check] %s: %s' % (d.getVar('PN'), line))
 }
+
+# Perform any additional adjustments needed to make rootf binary reproducible
+rootfs_reproducible () {
+       if [ "${REPRODUCIBLE_TIMESTAMP_ROOTFS}" != "" ]; then
+               # Convert UTC into %4Y%2m%2d%2H%2M%2S
+               sformatted=`date -u -d @${REPRODUCIBLE_TIMESTAMP_ROOTFS} +%4Y%2m%2d%2H%2M%2S`
+               echo $sformatted > ${IMAGE_ROOTFS}/etc/version
+               bbnote "rootfs_reproducible: set /etc/version to $sformatted"
+
+               find ${IMAGE_ROOTFS}/etc/gconf -name '%gconf.xml' -print0 | xargs -0r \
+               sed -i -e 's@\bmtime="[0-9][0-9]*"@mtime="'${REPRODUCIBLE_TIMESTAMP_ROOTFS}'"@g'
+       fi
+}