]> code.ossystems Code Review - openembedded-core.git/commitdiff
bitbake-dev: Remve the need for the cache for -e -b options
authorRichard Purdie <rpurdie@linux.intel.com>
Thu, 23 Jul 2009 18:51:56 +0000 (19:51 +0100)
committerRichard Purdie <rpurdie@linux.intel.com>
Thu, 23 Jul 2009 18:51:56 +0000 (19:51 +0100)
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
bitbake-dev/lib/bb/command.py
bitbake-dev/lib/bb/cooker.py

index 4cab78e43bc254879e22558626bf54b633ac0bfb..9226a2772fe78d12c96320c7734b153dd5364917 100644 (file)
@@ -203,23 +203,25 @@ class CommandsAsync:
         command.finishAsyncCommand()
     showVersions.needcache = True
 
-    def showEnvironmentPackage(self, command, params):
+    def showEnvironmentTarget(self, command, params):
         """
-        Print the environment of a recipe
+        Print the environment of a target recipe
+        (needs the cache to work out which recipe to use)
         """
-        bfile = params[0]
-        pkg = params[1]
+        pkg = params[0]
 
-        command.cooker.showEnvironment(bfile, pkg)
+        command.cooker.showEnvironment(None, pkg)
         command.finishAsyncCommand()
-    showEnvironmentPackage.needcache = True
+    showEnvironmentTarget.needcache = True
 
     def showEnvironment(self, command, params):
         """
         Print the standard environment
+        or if specified the environment for a specified recipe
         """
+        bfile = params[0]
 
-        command.cooker.showEnvironment()
+        command.cooker.showEnvironment(bfile)
         command.finishAsyncCommand()
     showEnvironment.needcache = False
 
index dceebb12d5760ce1ae285ed4c613a846b55879ce..bec6c3535ca6ee873a900254a33f42bc994cca0a 100644 (file)
@@ -141,10 +141,10 @@ class BBCooker:
                 bb.error("Only one target can be used with the --environment option.")
             elif self.configuration.buildfile and len(self.configuration.pkgs_to_build) > 0:
                 bb.error("No target should be used with the --environment and --buildfile options.")
-            elif self.configuration.buildfile is not None or len(self.configuration.pkgs_to_build) > 0:
-                self.commandlineAction = ["showEnvironmentPackage", self.configuration.buildfile, self.configuration.pkgs_to_build]
+            elif len(self.configuration.pkgs_to_build) > 0:
+                self.commandlineAction = ["showEnvironmentTarget", self.configuration.pkgs_to_build]
             else:
-                self.commandlineAction = ["showEnvironment"]
+                self.commandlineAction = ["showEnvironment", self.configuration.buildfile]
         elif self.configuration.buildfile is not None:
             self.commandlineAction = ["buildFile", self.configuration.buildfile, self.configuration.cmd]
         elif self.configuration.show_versions: