]> code.ossystems Code Review - openembedded-core.git/commitdiff
bootimg: Fix a math thinko in the block count calculation
authorDarren Hart <dvhart@linux.intel.com>
Wed, 11 Apr 2012 17:51:12 +0000 (10:51 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 14 Apr 2012 22:05:16 +0000 (23:05 +0100)
Fixes [YOCTO #1852] ... again.

The conversion from sectors to blocks was multiplying by 2 instead
of dividing by 2. Blocks are 1024 bytes, sectors are 512 bytes. The
result was images being much larger than intended.

Reported-by: Tom Zanussi <tom.zanussi@intel.com>
(From OE-Core rev: b35384fa3ca96b31c63d764322215abced2066e4)

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Backported to edison by Darren Hart.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/bootimg.bbclass

index c2d43c86eebc046c253e5d197a3a9747809d006f..489819b815d077e82194deef449dfb6ae1d88b25 100644 (file)
@@ -92,7 +92,8 @@ build_boot_bin() {
        SECTORS=$(expr $SECTORS + $(expr $DIR_SECTORS + $FAT_SECTORS))
 
        # Determine the final size in blocks accounting for some padding
-       BLOCKS=$(expr $(expr $SECTORS \* 2) + ${BOOTIMG_EXTRA_SPACE})
+       BLOCKS=$(expr $(expr $SECTORS / 2) + ${BOOTIMG_EXTRA_SPACE})
+
 
        # Ensure total sectors is an integral number of sectors per
        # track or mcopy will complain. Sectors are 512 bytes, and we