]> code.ossystems Code Review - openembedded-core.git/commitdiff
gcc-runtime: Add missing libc dependency
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 18 Dec 2018 11:52:56 +0000 (11:52 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 18 Dec 2018 16:19:30 +0000 (16:19 +0000)
For reasons lost in the depths of time, perhaps performane related,
we only have a dependency on libc at packaging time. This is too late,
as demonstrated by a recent build failure on non-IA builds where
the glibc 2.29 upgrade had been removed from the build:

ld: recipe-sysroot/usr/lib/../lib/libstdc++.so: undefined reference to `log@GLIBC_2.29'

libstdc++ should have been rebuilt but had not as the dependency
wasn't present.

Add the missing dependency to avoid this problem (and drop the other
form of dependency which is no longer needed).

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/gcc/gcc-runtime.inc

index 9e7e7c5b3d692b402d72c1614a7a13e33ab6a4e8..95153da20cdfe46bae365a33d765f0d39846e0f0 100644 (file)
@@ -128,7 +128,7 @@ do_install_append_class-target () {
 }
 
 INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++ libgcc"
+DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++ libgcc virtual/${MLPREFIX}libc"
 PROVIDES = "virtual/${TARGET_PREFIX}compilerlibs"
 
 BBCLASSEXTEND = "nativesdk"
@@ -288,7 +288,3 @@ FILES_libmpx-dev = "\
 SUMMARY_libmpx-dev = "Intel Memory Protection Extension library - development files"
 FILES_libmpx-staticdev = "${libdir}/libmpx.a ${libdir}/libmpxwrappers.a"
 SUMMARY_libmpx-staticdev = "Intel Memory Protection Extension library - static development files"
-
-do_package_write_ipk[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
-do_package_write_deb[depends] += "virtual/${MLPREFIX}libc:do_packagedata"
-do_package_write_rpm[depends] += "virtual/${MLPREFIX}libc:do_packagedata"