]> code.ossystems Code Review - openembedded-core.git/commitdiff
kernel-yocto: relax BSP definition test
authorBruce Ashfield <bruce.ashfield@windriver.com>
Wed, 23 Aug 2017 19:20:20 +0000 (15:20 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 24 Aug 2017 08:37:11 +0000 (09:37 +0100)
commit 44aea7b873 [kernel-yocto: ensure that only valid BSPs are built]
introduced a new check to ensure that a valid BSP definition was found,
rather than building something that 'closely' matched the current
MACHINE.

This check breaks valid configurations which do not have a bsp
definition but are otherwise completely configured machines.

To allow both elements to co-exist (and not add warnings or errors
to otherwise valid builds), we first check to see if an empty bsp
definition was found, but then check to see if a defconfig was
provided.

If a defconfig has been provided, that is a sign that the board
configuration is complete and we should continue the build without
otherwise bothering the user.

Tested on meta-raspberrypi and linux-yocto*

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/kernel-yocto.bbclass

index c8ed1e9108c732f70129b957a4d5b84dfc4cdf2b..1d447951c49a1885f220b0762337dec1d2862f64 100644 (file)
@@ -143,8 +143,11 @@ do_kernel_metadata() {
 
        # expand kernel features into their full path equivalents
        bsp_definition=$(spp ${includes} --find -DKMACHINE=${KMACHINE} -DKTYPE=${LINUX_KERNEL_TYPE})
-       if [ $? -ne 0 ] || [ -z "${bsp_definition}" ]; then
-               bbfatal_log "Could not locate BSP definiton for ${KMACHINE}/${LINUX_KERNEL_TYPE}."
+       if [ -z "$bsp_definition" ]; then
+               echo "$sccs" | grep -q defconfig
+               if [ $? -ne 0 ]; then
+                       bberror "Could not locate BSP definition for ${KMACHINE}/${LINUX_KERNEL_TYPE} and no defconfig was provided"
+               fi
        fi
        meta_dir=$(kgit --meta)