kernel: fitimage: Repair misuse of shell test command

The kernel fitImage must be amended with signature if and only if
UBOOT_SIGN_ENABLE = 1 . In the current case, the UBOOT_SIGN_ENABLE
could be either 0 (default) or 1 , which test -n always correctly
interprets as non-empty string, thus always true. This does not
match the logic above though, so replace the test with check which
passes only for UBOOT_SIGN_ENABLE = 1 .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Yannick Gicquel <yannick.gicquel@iot.bzh>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Ross Burton <ross.burton@intel.com>

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 809bd4d698ab6352fdc383cb52888261070eeb6d..298eda2a2318a8b156efa259fe25edc28ea93035 100644 (file)
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -250,7 +250,7 @@ do_assemble_fitimage() {
                #
                # Step 5: Sign the image and add public key to U-Boot dtb
                #
-               if test -n "${UBOOT_SIGN_ENABLE}"; then
+               if [ "x${UBOOT_SIGN_ENABLE}" = "x1" ] ; then
                        uboot-mkimage \
                                ${@'-D "${UBOOT_MKIMAGE_DTCOPTS}"' if len('${UBOOT_MKIMAGE_DTCOPTS}') else ''} \
                                -F -k "${UBOOT_SIGN_KEYDIR}" \