oe-selftest: Improved --list-classes when determining test names

--list-classes does a weak validation when determining test names:
(if method.startswith("test_") which could report any class attribute
that starts with 'test_' as a valid test case.

This fix checks that the class attribute that starts with 'test_'
is also callable (is a method).

Fix for [YOCTO #8862]

Signed-off-by: Daniel Istrate <daniel.alexandrux.istrate@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>

diff --git a/scripts/oe-selftest b/scripts/oe-selftest
index bd903f9e68fee6efdf724d60fc832ec0ac3b4d54..c32c419e19e5ae73b806fc9139fd9cdcd63bda75 100755 (executable)
--- a/scripts/oe-selftest
+++ b/scripts/oe-selftest
@@ -453,7 +453,7 @@ def main():
                         if isinstance(t, type(oeSelfTest)) and issubclass(t, oeSelfTest) and t!=oeSelfTest:
                             print " --", v
                             for method in dir(t):
-                                if method.startswith("test_"):
+                                if method.startswith("test_") and callable(vars(t)[method]):
                                     print " --  --", method
 
                 except (AttributeError, ImportError) as e: