]> code.ossystems Code Review - openembedded-core.git/commitdiff
rpcbind: make service socket activated
authorChen Qi <Qi.Chen@windriver.com>
Thu, 9 Oct 2014 05:35:07 +0000 (13:35 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 10 Oct 2014 09:39:13 +0000 (10:39 +0100)
Instead of setting 'Restart=always' in the service file, we should
make the service socket activated, just like what Fedora does.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
meta/recipes-extended/rpcbind/rpcbind/rpcbind.service
meta/recipes-extended/rpcbind/rpcbind/rpcbind.socket [new file with mode: 0644]
meta/recipes-extended/rpcbind/rpcbind_0.2.1.bb

index 33ee268441d98efe67de37ec926941b6967c1664..b3ae2541a0667b5060f331d01daf71ca267012ac 100644 (file)
@@ -1,15 +1,12 @@
 [Unit]
-Description=RPC Bind
-After=network.target
-Wants=rpcbind.target
-Before=rpcbind.target
+Description=RPC Bind Service
+Requires=rpcbind.socket
 
 [Service]
 Type=forking
 EnvironmentFile=-@SYSCONFDIR@/rpcbind.conf
 ExecStart=@SBINDIR@/rpcbind -w $RPCBIND_OPTS
-Restart=always
 SuccessExitStatus=2
 
 [Install]
-WantedBy=multi-user.target
+Also=rpcbind.socket
diff --git a/meta/recipes-extended/rpcbind/rpcbind/rpcbind.socket b/meta/recipes-extended/rpcbind/rpcbind/rpcbind.socket
new file mode 100644 (file)
index 0000000..d63c1d9
--- /dev/null
@@ -0,0 +1,8 @@
+[Unit]
+Description=RPCbind Server Activation Socket
+
+[Socket]
+ListenStream=/var/run/rpcbind.sock
+
+[Install]
+WantedBy=sockets.target
index 4a5562b7d2b28c5e82b7cfb6cb9b596f24cff5cf..b7324766f722d13edb3818e89f34a56b0d832aeb 100644 (file)
@@ -15,6 +15,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/rpcbind/rpcbind-${PV}.tar.bz2 \
            file://init.d \
            ${UCLIBCPATCHES} \
            file://rpcbind.conf \
+           file://rpcbind.socket \
            file://rpcbind.service \
           "
 
@@ -34,8 +35,7 @@ PACKAGECONFIG[tcp-wrappers] = "--enable-libwrap,--disable-libwrap,tcp-wrappers"
 INITSCRIPT_NAME = "rpcbind"
 INITSCRIPT_PARAMS = "start 12 2 3 4 5 . stop 60 0 1 6 ."
 
-SYSTEMD_SERVICE_${PN} = "rpcbind.service"
-SYSTEMD_AUTO_ENABLE = "disable"
+SYSTEMD_SERVICE_${PN} = "rpcbind.service rpcbind.socket"
 
 inherit useradd
 
@@ -56,6 +56,7 @@ do_install_append () {
 
        install -m 0755 ${WORKDIR}/rpcbind.conf ${D}${sysconfdir}
        install -d ${D}${systemd_unitdir}/system
+       install -m 0644 ${WORKDIR}/rpcbind.socket ${D}${systemd_unitdir}/system
        install -m 0644 ${WORKDIR}/rpcbind.service ${D}${systemd_unitdir}/system
        sed -i -e 's,@SBINDIR@,${sbindir},g' \
                -e 's,@SYSCONFDIR@,${sysconfdir},g' \