]> code.ossystems Code Review - openembedded-core.git/commitdiff
pixbufcache: add error exit in pixbufcache_sstate_postinst
authorJoe Slater <jslater@windriver.com>
Tue, 22 Apr 2014 18:00:41 +0000 (11:00 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 24 Apr 2014 16:54:55 +0000 (17:54 +0100)
In order to attempt recovery of a failed populate_sysroot_setscene,
we need to explicitly error exit an SSTATEPOSTINSTFUNC.  So, we test
the return value of gdk-pixbuf-query-loaders.

Signed-off-by: Joe Slater <jslater@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/pixbufcache.bbclass

index 922174dffea23471aadedb5f203d6711c396263b..b8d75bd38ccc7eab266da90f4db1679a3e058eeb 100644 (file)
@@ -46,14 +46,16 @@ python populate_packages_append() {
 }
 
 #
-# Add a sstate postinst hook to update the cache for native packages
+# Add an sstate postinst hook to update the cache for native packages.
+# An error exit during populate_sysroot_setscene allows bitbake to
+# try to recover by re-building the package.
 #
 SSTATEPOSTINSTFUNCS_append_class-native = " pixbufcache_sstate_postinst"
 
 pixbufcache_sstate_postinst() {
        if [ "${BB_CURRENTTASK}" = "populate_sysroot" -o "${BB_CURRENTTASK}" = "populate_sysroot_setscene" ]
        then
-               GDK_PIXBUF_FATAL_LOADER=1 gdk-pixbuf-query-loaders --update-cache
+               GDK_PIXBUF_FATAL_LOADER=1 gdk-pixbuf-query-loaders --update-cache || exit 1
        fi
 }