]> code.ossystems Code Review - openembedded-core.git/commitdiff
sstatesig: Further optimise
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 15 Dec 2019 17:44:35 +0000 (17:44 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 16 Dec 2019 23:22:03 +0000 (23:22 +0000)
Optimise the call into the parent function to be only when needed.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oe/sstatesig.py

index 8d009bfdc6e5fb07ed593161fb3045d01c639707..7cecb59d8e8b3f3a268901da2954fee0251fbe8f 100644 (file)
@@ -141,14 +141,13 @@ class SignatureGeneratorOEBasicHashMixIn(object):
         return super(bb.siggen.SignatureGeneratorBasicHash, self).dump_sigs(dataCache, options)
 
     def get_taskhash(self, tid, deps, dataCache):
-        h = super(bb.siggen.SignatureGeneratorBasicHash, self).get_taskhash(tid, deps, dataCache)
         if tid in self.lockedhashes:
             if self.lockedhashes[tid]:
                 return self.lockedhashes[tid]
             else:
-                return h
+                return super().get_taskhash(tid, deps, dataCache)
 
-        h = super(bb.siggen.SignatureGeneratorBasicHash, self).get_taskhash(tid, deps, dataCache)
+        h = super().get_taskhash(tid, deps, dataCache)
 
         (mc, _, task, fn) = bb.runqueue.split_tid_mcfn(tid)