]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic: don't set creator.bootimg_dir in plugins
authorEd Bartosh <ed.bartosh@linux.intel.com>
Wed, 22 Mar 2017 13:42:26 +0000 (15:42 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 22 Mar 2017 15:07:37 +0000 (15:07 +0000)
Changing bootimg_dir in plugins is a dangerous hack as this
value comes from wic command line and can be used by multiple
plugins.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/wic/plugins/source/bootimg-efi.py
scripts/lib/wic/plugins/source/bootimg-pcbios.py

index 2d793a5cb7d1ef7c0b9c774d84b60faedc37df3a..2d1c4d4089720b57324a645798c118a2ff248be3 100644 (file)
@@ -189,8 +189,6 @@ class BootimgEFIPlugin(SourcePlugin):
             bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
             if not bootimg_dir:
                 raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")
-            # just so the result notes display it
-            creator.bootimg_dir = bootimg_dir
 
         staging_kernel_dir = kernel_dir
 
index bd03eaa2286570dddf67c4c8490298a45a59ccb9..17795200441f9fd1375a2556f3983850aeaea8be 100644 (file)
@@ -153,8 +153,6 @@ class BootimgPcbiosPlugin(SourcePlugin):
                 raise WicError("Couldn't find STAGING_DATADIR, exiting")
             if not _has_syslinux(bootimg_dir):
                 raise WicError("Please build syslinux first")
-            # just so the result notes display it
-            creator.bootimg_dir = bootimg_dir
 
         staging_kernel_dir = kernel_dir