]> code.ossystems Code Review - openembedded-core.git/commitdiff
libsecret: Improve determimism
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 25 Feb 2021 15:19:22 +0000 (15:19 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 26 Feb 2021 15:19:28 +0000 (15:19 +0000)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/selftest/cases/reproducible.py
meta/recipes-gnome/libsecret/libsecret/determinism.patch [new file with mode: 0644]
meta/recipes-gnome/libsecret/libsecret_0.20.4.bb

index ec8ac0bcc84439b7740532963faee8f784c9b433..03a29241c7d0fe8434e43d23eb6e78e2246fd473 100644 (file)
@@ -41,8 +41,6 @@ exclude_packages = [
        'libaprutil',
        'libhandy-1-src',
        'libid3tag',
-       'libsecret-dev',
-       'libsecret-src',
        'lttng-tools-dbg',
        'lttng-tools-ptest',
        'ltp',
diff --git a/meta/recipes-gnome/libsecret/libsecret/determinism.patch b/meta/recipes-gnome/libsecret/libsecret/determinism.patch
new file mode 100644 (file)
index 0000000..ad96e8f
--- /dev/null
@@ -0,0 +1,37 @@
+secret-enum-types.c/h.template: Fix reproducibility issue 
+
+When full filenames are used in generated sources it makes the resulting
+debug packages non-reproducible. Best practise is to use basename in
+comments instead.
+
+Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org
+Upstream-Status: Submitted [https://gitlab.gnome.org/GNOME/libsecret/-/merge_requests/68]
+
+Index: libsecret-0.20.4/libsecret/secret-enum-types.c.template
+===================================================================
+--- libsecret-0.20.4.orig/libsecret/secret-enum-types.c.template
++++ libsecret-0.20.4/libsecret/secret-enum-types.c.template
+@@ -23,8 +23,8 @@
+ /*** END file-header ***/
+ /*** BEGIN file-production ***/
+-#include "@filename@"
+-/* enumerations from "@filename@" */
++#include "@basename@"
++/* enumerations from "@basename@" */
+ /*** END file-production ***/
+ /*** BEGIN value-header ***/
+Index: libsecret-0.20.4/libsecret/secret-enum-types.h.template
+===================================================================
+--- libsecret-0.20.4.orig/libsecret/secret-enum-types.h.template
++++ libsecret-0.20.4/libsecret/secret-enum-types.h.template
+@@ -27,7 +27,7 @@ G_BEGIN_DECLS
+ /*** BEGIN file-production ***/
+-/* enumerations from "@filename@" */
++/* enumerations from "@basename@" */
+ /*** END file-production ***/
+ /*** BEGIN value-header ***/
index 96f6460181d999f3a36f04adc5800a7762c05412..4b6b2172e4e85155dbbc021c809edda006e12fc6 100644 (file)
@@ -13,6 +13,8 @@ inherit gnomebase gtk-doc vala gobject-introspection manpages
 
 DEPENDS += "glib-2.0 libgcrypt gettext-native"
 
+SRC_URI += " file://determinism.patch"
+
 SRC_URI[archive.sha256sum] = "325a4c54db320c406711bf2b55e5cb5b6c29823426aa82596a907595abb39d28"
 
 GTKDOC_MESON_OPTION = 'gtk_doc'