]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic/engine: lets display an error not a traceback
authorArmin Kuster <akuster808@gmail.com>
Mon, 2 Mar 2020 05:39:56 +0000 (21:39 -0800)
committerArmin Kuster <akuster808@gmail.com>
Wed, 11 Mar 2020 02:15:57 +0000 (19:15 -0700)
If the requested partition does not exist in this request "wic ls {path}:pnum"
display a nice message not a trackback

Also fix displaying the pnum and not "%s"

Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 15d1722950a22649905cf8a5789d3cfe48a2a892)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
scripts/lib/wic/engine.py

index 18776fa8a0091a6d1e0e8437a8468d5b8c9069b0..4ccca482e761cb709683b7c4a6d8011aeb04c210 100644 (file)
@@ -290,7 +290,7 @@ class Disk:
 
     def _get_part_image(self, pnum):
         if pnum not in self.partitions:
-            raise WicError("Partition %s is not in the image")
+            raise WicError("Partition %s is not in the image" % pnum)
         part = self.partitions[pnum]
         # check if fstype is supported
         for fstype in self.fstypes:
@@ -313,6 +313,9 @@ class Disk:
                     seek=self.partitions[pnum].start)
 
     def dir(self, pnum, path):
+        if pnum not in self.partitions:
+            raise WicError("Partition %s is not in the image" % pnum)
+
         if self.partitions[pnum].fstype.startswith('ext'):
             return exec_cmd("{} {} -R 'ls -l {}'".format(self.debugfs,
                                                          self._get_part_image(pnum),