]> code.ossystems Code Review - openembedded-core.git/commitdiff
psplash: Clean up getstatusoutput usage
authorRobert Yang <liezhi.yang@windriver.com>
Thu, 23 Aug 2018 08:07:27 +0000 (16:07 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 23 Aug 2018 17:02:19 +0000 (18:02 +0100)
Replace usage of oe.utils.getstatusoutput() with direct subprocess calls.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/psplash/psplash_git.bb

index aab2c0360deee621c3c12bacb5d0a2e5cccee9f7..3ad1ef48157efc9cb562ca70e548cd7c48d819ac 100644 (file)
@@ -73,6 +73,8 @@ ALTERNATIVE_LINK_NAME[psplash] = "${bindir}/psplash"
 
 python do_compile () {
     import shutil
+    import subprocess
+    import shlex
 
     # Build a separate executable for each splash image
     workdir = d.getVar('WORKDIR')
@@ -82,8 +84,7 @@ python do_compile () {
     outputfiles = d.getVar('SPLASH_INSTALL').split()
     for localfile, outputfile in zip(localfiles, outputfiles):
         if localfile.endswith(".png"):
-            outp = oe.utils.getstatusoutput('%s %s POKY' % (convertscript, os.path.join(workdir, localfile)))
-            print(outp[1])
+            subprocess.call(shlex.split('%s %s POKY' % (convertscript, os.path.join(workdir, localfile))))
             fbase = os.path.splitext(localfile)[0]
             shutil.copyfile("%s-img.h" % fbase, destfile)
         else: