]> code.ossystems Code Review - openembedded-core.git/commitdiff
patch: reproducibility: Fix host umask leakage
authorDouglas Royds <douglas.royds@taitradio.com>
Thu, 20 Dec 2018 23:10:22 +0000 (12:10 +1300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 8 Jan 2019 19:54:01 +0000 (19:54 +0000)
Some patch files create entirely new files, so their permissions are subject to
the host umask. If such a file is later installed into a package with no change
in permissions, it breaks the reproducibility of the package.

This was observed on libpam, for instance: The patch file
pam-security-abstract-securetty-handling.patch creates a new file
(tty_secure.c). This file is later copied into the -dbg package with no change
in permissions.

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/patch.bbclass

index 3e0a18182183aae9f6424c5254d131e27b24e70b..cd241f1c848cd6dc5aff491fb8121411fc6c25e5 100644 (file)
@@ -153,6 +153,7 @@ python patch_do_patch() {
 patch_do_patch[vardepsexclude] = "PATCHRESOLVE"
 
 addtask patch after do_unpack
+do_patch[umask] = "022"
 do_patch[dirs] = "${WORKDIR}"
 do_patch[depends] = "${PATCHDEPENDENCY}"