]> code.ossystems Code Review - openembedded-core.git/commitdiff
classes/license: use "1" to set boolean variables
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Wed, 13 Nov 2013 14:32:44 +0000 (14:32 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 14 Nov 2013 13:39:10 +0000 (13:39 +0000)
The expected usage of COPY_LIC_MANIFEST and COPY_LIC_DIRS appears to be
to set them to "1" to enable; however the test here is just testing
whether they have a value at all, so setting them to "0" would also
enable them which is somewhat disingenuous. Actually check if they are
set to "1" instead in order to fix this.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/license.bbclass

index c1483ac4905de775cfd2385dc9ebdc09aac9edc3..6d7ee941198dbc1cd24db162a18770ea8482c3ba 100644 (file)
@@ -62,10 +62,10 @@ license_create_manifest() {
        # - Just copy the manifest
        # - Copy the manifest and the license directories
        # With both options set we see a .5 M increase in core-image-minimal
-       if [ -n "${COPY_LIC_MANIFEST}" ]; then
+       if [ "${COPY_LIC_MANIFEST}" = "1" ]; then
                mkdir -p ${IMAGE_ROOTFS}/usr/share/common-licenses/
                cp ${LICENSE_MANIFEST} ${IMAGE_ROOTFS}/usr/share/common-licenses/license.manifest
-               if [ -n "${COPY_LIC_DIRS}" ]; then
+               if [ "${COPY_LIC_DIRS}" = "1" ]; then
                        for pkg in ${INSTALLED_PKGS}; do
                                mkdir -p ${IMAGE_ROOTFS}/usr/share/common-licenses/${pkg}
                                for lic in `ls ${LICENSE_DIRECTORY}/${pkg}`; do