]> code.ossystems Code Review - openembedded-core.git/commitdiff
recipes: Replace "cp -a" with "cp -R --no-dereference --preserve=mode, links"
authorMartin Jansa <martin.jansa@gmail.com>
Tue, 30 May 2017 08:08:36 +0000 (10:08 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 5 Jun 2017 16:59:40 +0000 (17:59 +0100)
* Using "cp -a" leaks UID of user running the builds, causing
  many QA warnings.
* See this thread for details:
  http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112904.html

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/coreutils/coreutils_8.27.bb
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.4.bb
meta/recipes-extended/mdadm/mdadm_4.0.bb

index 667e0af560c3c792fd2189b784236824db196784..ea8740a2d114ac071f4ca4700935d3d56934e780 100644 (file)
@@ -99,7 +99,7 @@ do_install_append() {
        install -t ${D}/${mandir}/man1 ${S}/man/*.1
        # prebuilt man pages don't do a separate man page for [ vs test.
        # see comment above r.e. sed and update-alternatives
-       cp -a ${D}${mandir}/man1/test.1 ${D}${mandir}/man1/lbracket.1.${BPN}
+       cp -R --no-dereference --preserve=mode,links -v ${D}${mandir}/man1/test.1 ${D}${mandir}/man1/lbracket.1.${BPN}
 }
 
 inherit update-alternatives
index 5216c7027ca10abbbdbeab55af6123baf0da0fbe..7c8809a41e27e6077d9138de904b0e5e6532ab0a 100644 (file)
@@ -106,7 +106,7 @@ do_compile_ptest() {
 }
 
 do_install_ptest() {
-       cp -a ${B}/tests ${D}${PTEST_PATH}/test
-       cp -a ${S}/tests/* ${D}${PTEST_PATH}/test
+       cp -R --no-dereference --preserve=mode,links -v ${B}/tests ${D}${PTEST_PATH}/test
+       cp -R --no-dereference --preserve=mode,links -v ${S}/tests/* ${D}${PTEST_PATH}/test
        sed -e 's!../e2fsck/e2fsck!e2fsck!g' -i ${D}${PTEST_PATH}/test/*/expect*
 }
index 98a10a8b15d9c73a591f6da67ac9a6a0cca7c2a7..506b0bc315ba97898ba3dba33dfa37a2ee93cf7a 100644 (file)
@@ -55,7 +55,7 @@ do_compile_ptest() {
 }
 
 do_install_ptest() {
-       cp -a ${S}/tests ${D}${PTEST_PATH}/tests
+       cp -R --no-dereference --preserve=mode,links -v ${S}/tests ${D}${PTEST_PATH}/tests
        cp ${S}/test ${D}${PTEST_PATH}
        sed -e 's!sleep 0.*!sleep 1!g; s!/var/tmp!/!g' -i ${D}${PTEST_PATH}/test
        ln -s ${base_sbindir}/mdadm ${D}${PTEST_PATH}/mdadm