]> code.ossystems Code Review - openembedded-core.git/commitdiff
yocto-compat-layer.py: Fix trace when layers can't be processed
authorMark Hatle <mark.hatle@windriver.com>
Tue, 5 Sep 2017 02:10:11 +0000 (21:10 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 11 Sep 2017 16:30:10 +0000 (17:30 +0100)
When all of the requested layers have unsatisfied dependencies, an error
can occur.  Check for the condition to avoid the traceback:

Traceback (most recent call last):
  File "../scripts/yocto-compat-layer.py", line 203, in <module>
    ret =  main()
  File "../scripts/yocto-compat-layer.py", line 194, in main
    if not results[layer_name].wasSuccessful():
AttributeError: 'NoneType' object has no attribute 'wasSuccessful'

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
scripts/yocto-compat-layer.py

index a16974f98f064a185f595c117f2a7bc85e53fde5..9a541c66e57f131137949101d1b7f5dacc40a81a 100755 (executable)
@@ -191,7 +191,7 @@ def main():
         logger.info('')
         for layer_name in results_status:
             logger.info('%s ... %s' % (layer_name, results_status[layer_name]))
-            if not results[layer_name].wasSuccessful():
+            if not results[layer_name] or not results[layer_name].wasSuccessful():
                 ret = 2 # ret = 1 used for initialization errors
 
     cleanup_bblayers(None, None)