]> code.ossystems Code Review - openembedded-core.git/commitdiff
libxml2: security fix CVE-2015-8317
authorArmin Kuster <akuster@mvista.com>
Sat, 5 Dec 2015 18:54:29 +0000 (10:54 -0800)
committerJoshua Lock <joshua.g.lock@intel.com>
Fri, 15 Jan 2016 15:12:53 +0000 (15:12 +0000)
Signed-off-by: Armin Kuster <akuster@mvista.com>
Signed-off-by: Joshua Lock <joshua.g.lock@intel.com>
meta/recipes-core/libxml/libxml2.inc
meta/recipes-core/libxml/libxml2/CVE-2015-8317-Fail-parsing-early-on-if-encoding-conversion-failed.patch [new file with mode: 0644]

index 9ebb8bbeab8a81b7ae3759109dfa20ac7356b7f8..180dd66bce516d59dea148061d4b7315e6027c3d 100644 (file)
@@ -25,6 +25,7 @@ SRC_URI = "ftp://xmlsoft.org/libxml2/libxml2-${PV}.tar.gz;name=libtar \
            file://0001-CVE-2015-1819-Enforce-the-reader-to-run-in-constant-.patch \
            file://CVE-2015-7941-1-Stop-parsing-on-entities-boundaries-errors.patch \
            file://CVE-2015-7941-2-Cleanup-conditional-section-error-handling.patch \
+           file://CVE-2015-8317-Fail-parsing-early-on-if-encoding-conversion-failed.patch \
           "
 
 BINCONFIG = "${bindir}/xml2-config"
diff --git a/meta/recipes-core/libxml/libxml2/CVE-2015-8317-Fail-parsing-early-on-if-encoding-conversion-failed.patch b/meta/recipes-core/libxml/libxml2/CVE-2015-8317-Fail-parsing-early-on-if-encoding-conversion-failed.patch
new file mode 100644 (file)
index 0000000..59425cb
--- /dev/null
@@ -0,0 +1,42 @@
+From 709a952110e98621c9b78c4f26462a9d8333102e Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <veillard@redhat.com>
+Date: Mon, 29 Jun 2015 16:10:26 +0800
+Subject: [PATCH] Fail parsing early on if encoding conversion failed
+
+For https://bugzilla.gnome.org/show_bug.cgi?id=751631
+
+If we fail conversing the current input stream while
+processing the encoding declaration of the XMLDecl
+then it's safer to just abort there and not try to
+report further errors.
+
+Upstream-Status: Backport
+
+CVE-2015-8317
+
+Signed-off-by: Armin Kuster <akuster@mvista.com>
+
+---
+ parser.c | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/parser.c b/parser.c
+index a3a9568..0edd53b 100644
+--- a/parser.c
++++ b/parser.c
+@@ -10471,7 +10471,11 @@ xmlParseEncodingDecl(xmlParserCtxtPtr ctxt) {
+             handler = xmlFindCharEncodingHandler((const char *) encoding);
+           if (handler != NULL) {
+-              xmlSwitchToEncoding(ctxt, handler);
++              if (xmlSwitchToEncoding(ctxt, handler) < 0) {
++                  /* failed to convert */
++                  ctxt->errNo = XML_ERR_UNSUPPORTED_ENCODING;
++                  return(NULL);
++              }
+           } else {
+               xmlFatalErrMsgStr(ctxt, XML_ERR_UNSUPPORTED_ENCODING,
+                       "Unsupported encoding %s\n", encoding);
+-- 
+2.3.5
+