]> code.ossystems Code Review - openembedded-core.git/commitdiff
qemu: replace a gtk wrapper with directly setting environment from runqemu
authorAlexander Kanavin <alex@linutronix.de>
Sun, 6 Feb 2022 11:56:02 +0000 (12:56 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 7 Feb 2022 10:08:52 +0000 (10:08 +0000)
The wrapper is executed by host bash, and host bash refuses to run
when pseudo libc is preloaded via LD_PRELOAD (which is the case
when gl is enabled).

Only the fontconfig setting is carried over as local testing showed that
only that is necessary for the gui to look ok nowadays; adjust further
if necessary.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/qemu/qemu-native.inc
meta/recipes-devtools/qemu/qemu.inc
meta/recipes-devtools/qemu/qemu_6.2.0.bb
scripts/runqemu

index 5d3ba3486c153ca6e04b12090f21418d23a90e8b..d9acc613f95036dba77c3e288a0f5e6c09d401c2 100644 (file)
@@ -5,7 +5,3 @@ inherit native
 EXTRA_OEMAKE:append = " LD='${LD}' AR='${AR}' OBJCOPY='${OBJCOPY}' LDFLAGS='${LDFLAGS}'"
 
 LDFLAGS:append = " -fuse-ld=bfd"
-
-do_install:append() {
-     ${@bb.utils.contains('PACKAGECONFIG', 'gtk+', 'make_qemu_wrapper', '', d)}
-}
index 843de3337a563748f18601646bb3411f2497ae08..325118cfb369baeb2240fa50d2c13fc45d8edb39 100644 (file)
@@ -138,17 +138,6 @@ do_install:append() {
 }
 # END of qemu-mips workaround
 
-make_qemu_wrapper() {
-        gdk_pixbuf_module_file=`pkg-config --variable=gdk_pixbuf_cache_file gdk-pixbuf-2.0`
-
-        for tool in `ls ${D}${bindir}/qemu-system-*`; do
-                create_wrapper $tool \
-                        GDK_PIXBUF_MODULE_FILE=$gdk_pixbuf_module_file \
-                        FONTCONFIG_PATH=/etc/fonts \
-                        GTK_THEME=Adwaita
-        done
-}
-
 # Disable kvm/virgl/mesa on targets that do not support it
 PACKAGECONFIG:remove:darwin = "kvm virglrenderer glx gtk+"
 PACKAGECONFIG:remove:mingw32 = "kvm virglrenderer glx gtk+"
index c9a53e3b05b63699008da6876d4adb3e573dd85d..062ed32b01502dd19db2ebffabfbbf3e1988a4aa 100644 (file)
@@ -12,10 +12,6 @@ EXTRA_OECONF:append:class-target = " --target-list=${@get_qemu_target_list(d)}"
 EXTRA_OECONF:append:class-target:mipsarcho32 = "${@bb.utils.contains('BBEXTENDCURR', 'multilib', ' --disable-capstone', '', d)}"
 EXTRA_OECONF:append:class-nativesdk = " --target-list=${@get_qemu_target_list(d)}"
 
-do_install:append:class-nativesdk() {
-     ${@bb.utils.contains('PACKAGECONFIG', 'gtk+', 'make_qemu_wrapper', '', d)}
-}
-
 PACKAGECONFIG ??= " \
     fdt sdl kvm pie \
     ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \
index 4e05c1bb15ba1a3ec6ddfb4aec8c6b011cf979f1..07429372ea7c0f53f2ff90ac8ef3826fcb64f27f 100755 (executable)
@@ -1369,6 +1369,7 @@ class BaseConfig(object):
                 if self.sdl == True:
                     self.qemu_opt += 'sdl,'
                 elif self.gtk == True:
+                    os.environ['FONTCONFIG_PATH'] = '/etc/fonts'
                     self.qemu_opt += 'gtk,'
 
                 if self.gl == True: