]> code.ossystems Code Review - openembedded-core.git/commitdiff
libsndfile: fix CVE-2014-9756
authorMaxin B. John <maxin.john@intel.com>
Thu, 5 Nov 2015 15:56:09 +0000 (17:56 +0200)
committerRobert Yang <liezhi.yang@windriver.com>
Tue, 8 Dec 2015 08:18:12 +0000 (00:18 -0800)
Fix divide by zero bug (CVE-2014-9756)

(From OE-Core master rev: f47cf07ab9d00ed7eddc8e867138481f7bd2bb7d)

Signed-off-by: Maxin B. John <maxin.john@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
meta/recipes-multimedia/libsndfile/files/libsndfile-fix-CVE-2014-9756.patch [new file with mode: 0644]
meta/recipes-multimedia/libsndfile/libsndfile1_1.0.25.bb

diff --git a/meta/recipes-multimedia/libsndfile/files/libsndfile-fix-CVE-2014-9756.patch b/meta/recipes-multimedia/libsndfile/files/libsndfile-fix-CVE-2014-9756.patch
new file mode 100644 (file)
index 0000000..b54b3ba
--- /dev/null
@@ -0,0 +1,24 @@
+src/file_io.c : Prevent potential divide-by-zero.
+
+Closes: https://github.com/erikd/libsndfile/issues/92
+
+Upstream-Status: Backport
+
+Fixes CVE-2014-9756
+
+Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
+Signed-off-by: Maxin B. John <maxin.john@intel.com>
+---
+diff -Naur libsndfile-1.0.25-orig/src/file_io.c libsndfile-1.0.25/src/file_io.c
+--- libsndfile-1.0.25-orig/src/file_io.c       2011-01-19 12:12:28.000000000 +0200
++++ libsndfile-1.0.25/src/file_io.c    2015-11-04 15:02:04.337395618 +0200
+@@ -358,6 +358,9 @@
+ {     sf_count_t total = 0 ;
+       ssize_t count ;
++    if (bytes == 0 || items == 0)
++        return 0 ;
++
+       if (psf->virtual_io)
+               return psf->vio.write (ptr, bytes*items, psf->vio_user_data) / bytes ;
index 3e02f4ea788ad692789ba2b516bcb06e2fc93321..be875c227b782c19c2bcc8d239b6554daf07ce29 100644 (file)
@@ -9,6 +9,7 @@ PR = "r2"
 SRC_URI = "http://www.mega-nerd.com/libsndfile/files/libsndfile-${PV}.tar.gz \
            file://0001-src-sd2.c-Fix-segfault-in-SD2-RSRC-parser.patch \
            file://0001-src-sd2.c-Fix-two-potential-buffer-read-overflows.patch \
+           file://libsndfile-fix-CVE-2014-9756.patch \
 "
 
 SRC_URI[md5sum] = "e2b7bb637e01022c7d20f95f9c3990a2"