]> code.ossystems Code Review - openembedded-core.git/commitdiff
classes/rootfs_*: fix splitting package dependency strings
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Sun, 13 May 2012 08:52:57 +0000 (09:52 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 13 May 2012 19:07:24 +0000 (20:07 +0100)
If a + character appears in a version specification within the list of
package dependencies, the version will not be removed from the list in
list_package_depends/recommends leading to garbage appearing in the
dependency graphs generated by buildhistory. To avoid any future
problems due to unusual characters appearing in versions, change the
regex to match almost any character.

Fixes [YOCTO #2451].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/rootfs_deb.bbclass
meta/classes/rootfs_ipk.bbclass

index b6c706c580e6cbe0af399c8e29872b708d1fff6f..6c9767f98ec47c8d8a381a263c9de9dbe48b4123 100644 (file)
@@ -101,11 +101,11 @@ get_package_filename() {
 }
 
 list_package_depends() {
-       ${DPKG_QUERY_COMMAND} -s $1 | grep ^Depends | sed -e 's/^Depends: //' -e 's/,//g' -e 's:([=<>]* [0-9a-zA-Z.~\-]*)::g'
+       ${DPKG_QUERY_COMMAND} -s $1 | grep ^Depends | sed -e 's/^Depends: //' -e 's/,//g' -e 's:([=<>]* [^ )]*)::g'
 }
 
 list_package_recommends() {
-       ${DPKG_QUERY_COMMAND} -s $1 | grep ^Recommends | sed -e 's/^Recommends: //' -e 's/,//g' -e 's:([=<>]* [0-9a-zA-Z.~\-]*)::g'
+       ${DPKG_QUERY_COMMAND} -s $1 | grep ^Recommends | sed -e 's/^Recommends: //' -e 's/,//g' -e 's:([=<>]* [^ )]*)::g'
 }
 
 rootfs_check_package_exists() {
index cbc63f018246b315e6d2f4d945e522f04138cfb4..15800864a6c4208571a9a74a135281aae9dffc5a 100644 (file)
@@ -143,11 +143,11 @@ get_package_filename() {
 }
 
 list_package_depends() {
-       opkg-cl ${IPKG_ARGS} info $1 | grep ^Depends | sed -e 's/^Depends: //' -e 's/,//g' -e 's:([=<>]* [0-9a-zA-Z.~\-]*)::g'
+       opkg-cl ${IPKG_ARGS} info $1 | grep ^Depends | sed -e 's/^Depends: //' -e 's/,//g' -e 's:([=<>]* [^ )]*)::g'
 }
 
 list_package_recommends() {
-       opkg-cl ${IPKG_ARGS} info $1 | grep ^Recommends | sed -e 's/^Recommends: //' -e 's/,//g' -e 's:([=<>]* [0-9a-zA-Z.~\-]*)::g'
+       opkg-cl ${IPKG_ARGS} info $1 | grep ^Recommends | sed -e 's/^Recommends: //' -e 's/,//g' -e 's:([=<>]* [^ )]*)::g'
 }
 
 rootfs_check_package_exists() {