]> code.ossystems Code Review - openembedded-core.git/commitdiff
kernel-uimage.bbclass: indeed update var KERNEL_IMAGETYPE_FOR_MAKE
authorKai Kang <kai.kang@windriver.com>
Thu, 21 Jul 2016 08:52:58 +0000 (16:52 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 25 Jul 2016 22:47:00 +0000 (23:47 +0100)
The replace() method of the python string class doesn't replace
in-place, then the var KERNEL_IMAGETYPE_FOR_MAKE doesn't be updated as
design.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/kernel-uimage.bbclass

index 2a187f549296b1499589fdc0a86a0acdd3b1e7d1..340503a2d665402ee3d0af162f8ca300e5a5e773 100644 (file)
@@ -14,8 +14,7 @@ python __anonymous () {
         if d.getVar("KEEPUIMAGE", True) != 'yes':
             typeformake = d.getVar("KERNEL_IMAGETYPE_FOR_MAKE", True) or ""
             if "uImage" in typeformake.split():
-                typeformake.replace('uImage', 'vmlinux')
-            d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', typeformake)
+                d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', typeformake.replace('uImage', 'vmlinux'))
 }
 
 do_uboot_mkimage() {