]> code.ossystems Code Review - openembedded-core.git/commitdiff
kernel-yocto: Simplify no git repo case in do_kernel_checkout
authorPaul Barker <paul@pbarker.dev>
Mon, 2 Aug 2021 10:44:30 +0000 (11:44 +0100)
committerSteve Sakoman <steve@sakoman.com>
Mon, 16 Aug 2021 14:41:07 +0000 (04:41 -1000)
If the kernel sources are not fetched via git, a local git repository is
created in do_kernel_checkout. In this case we know that there will be
no remote branches and we will already be on the correct branch (since
only one branch will exist). So we can simplify things by skipping these
steps.

This also removes the assumption that the default git branch name will
be "master". Prior to this change, the final git checkout command in
do_kernel_checkout could fail if a local git repo was created and the
user had changed init.defaultBranch in their gitconfig.

Signed-off-by: Paul Barker <paul@pbarker.dev>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit af2a9c92d4498492ca23388c7b4bbed48abdc4d7)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/classes/kernel-yocto.bbclass

index 66cce92362246365e68c21abb5339d3acfda71ac..a1a073b73882d6b7088647b655aed03811aae048 100644 (file)
@@ -320,6 +320,21 @@ do_kernel_checkout() {
                        fi
                fi
                cd ${S}
+
+               # convert any remote branches to local tracking ones
+               for i in `git branch -a --no-color | grep remotes | grep -v HEAD`; do
+                       b=`echo $i | cut -d' ' -f2 | sed 's%remotes/origin/%%'`;
+                       git show-ref --quiet --verify -- "refs/heads/$b"
+                       if [ $? -ne 0 ]; then
+                               git branch $b $i > /dev/null
+                       fi
+               done
+
+               # Create a working tree copy of the kernel by checking out a branch
+               machine_branch="${@ get_machine_branch(d, "${KBRANCH}" )}"
+
+               # checkout and clobber any unimportant files
+               git checkout -f ${machine_branch}
        else
                # case: we have no git repository at all. 
                # To support low bandwidth options for building the kernel, we'll just 
@@ -341,21 +356,6 @@ do_kernel_checkout() {
                git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
                git clean -d -f
        fi
-
-       # convert any remote branches to local tracking ones
-       for i in `git branch -a --no-color | grep remotes | grep -v HEAD`; do
-               b=`echo $i | cut -d' ' -f2 | sed 's%remotes/origin/%%'`;
-               git show-ref --quiet --verify -- "refs/heads/$b"
-               if [ $? -ne 0 ]; then
-                       git branch $b $i > /dev/null
-               fi
-       done
-
-       # Create a working tree copy of the kernel by checking out a branch
-       machine_branch="${@ get_machine_branch(d, "${KBRANCH}" )}"
-
-       # checkout and clobber any unimportant files
-       git checkout -f ${machine_branch}
 }
 do_kernel_checkout[dirs] = "${S}"