]> code.ossystems Code Review - meta-freescale.git/commitdiff
dtc-145: Fix compile failure with latest master on musl
authorKhem Raj <raj.khem@gmail.com>
Sun, 7 Oct 2018 01:23:46 +0000 (18:23 -0700)
committerOtavio Salvador <otavio@ossystems.com.br>
Sun, 7 Oct 2018 14:09:29 +0000 (11:09 -0300)
This issue is primarily seen when building the target recipe on musl the
fix is a partial backport from upstream to get over the hump

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
recipes-kernel/dtc/dtc-145_git.bb
recipes-kernel/dtc/files/0001-Fix-compiler-warnings-seen-with-musl.patch [new file with mode: 0644]

index 2776cc5edba60deac4f19024d0975aa8983a2a73..2d4097bbade1bdbfffefc82874cff3b4527ea648 100644 (file)
@@ -7,12 +7,14 @@ LIC_FILES_CHKSUM = " \
 
 SRCREV = "22a65c5331c22979d416738eb756b9541672e00d"
 
+SRC_URI += "file://0001-Fix-compiler-warnings-seen-with-musl.patch \
+           "
 S = "${WORKDIR}/git"
 
-BBCLASSEXTEND = "native nativesdk"
-
 # only install the dtc binary renamed to dtc-145
 do_install () {
     install -d ${D}/${bindir}
     install -m 755 dtc ${D}/${bindir}/dtc-145
 }
+
+BBCLASSEXTEND = "native nativesdk"
diff --git a/recipes-kernel/dtc/files/0001-Fix-compiler-warnings-seen-with-musl.patch b/recipes-kernel/dtc/files/0001-Fix-compiler-warnings-seen-with-musl.patch
new file mode 100644 (file)
index 0000000..418a649
--- /dev/null
@@ -0,0 +1,55 @@
+From 50034ca2600ae07203f397af6d78e2e9ff16bc02 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sat, 6 Oct 2018 18:12:23 -0700
+Subject: [PATCH] Fix compiler warnings seen with musl
+
+Fixes
+
+checks.c:975:16: error: format '%ld' expects argument of type 'long
+int', but argument 6 has type 'unsigned int' [-Werror=format=]
+   FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple
+of %ld in node %s",
+                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+        prop->name, prop->val.len, sizeof(cell_t), node->fullpath);
+                                   ~~~~~~~~~~~~~~
+checks.c:96:23: note: in definition of macro 'FAIL'
+   check_msg((c), dti, __VA_ARGS__);   \
+                       ^~~~~~~~~~~
+checks.c: In function 'check_interrupts_property':
+checks.c:1166:16: error: format '%ld' expects argument of type 'long
+int', but argument 6 has type 'unsigned int' [-Werror=format=]
+   FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple
+of %ld in node %s",
+                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+        irq_prop->name, irq_prop->val.len, sizeof(cell_t),
+                                           ~~~~~~~~~~~~~~
+
+Upstream-Status: Backport [adapted from an upstream fix]
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ checks.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/checks.c b/checks.c
+index 902f2e3..08a3a29 100644
+--- a/checks.c
++++ b/checks.c
+@@ -972,7 +972,7 @@ static void check_property_phandle_args(struct check *c,
+       int cell, cellsize = 0;
+       if (prop->val.len % sizeof(cell_t)) {
+-              FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %ld in node %s",
++              FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %zu in node %s",
+                    prop->name, prop->val.len, sizeof(cell_t), node->fullpath);
+               return;
+       }
+@@ -1163,7 +1163,7 @@ static void check_interrupts_property(struct check *c,
+               return;
+       if (irq_prop->val.len % sizeof(cell_t))
+-              FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %ld in node %s",
++              FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %zu in node %s",
+                    irq_prop->name, irq_prop->val.len, sizeof(cell_t),
+                    node->fullpath);