]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic:direct.py: ignore invalid mountpoints during fstab update
authorMarkus Volk <f_l_k@t-online.de>
Sat, 25 Sep 2021 18:01:37 +0000 (20:01 +0200)
committerSteve Sakoman <steve@sakoman.com>
Sat, 11 Dec 2021 15:21:06 +0000 (05:21 -1000)
wic fstab-update creates invalid entries for partitons that are not supposed to
be mounted from userspace eg u-boot partitions.

The following lines were added to fstab on a rock-pi-4:
/dev/mmcblk1p1 loader1 vfat defaults 0 0
/dev/mmcblk1p2 reserved1 vfat defaults 0 0
/dev/mmcblk1p3 reserved2 vfat defaults 0 0
/dev/mmcblk1p4 loader2 vfat defaults 0 0
/dev/mmcblk1p5 atf vfat defaults 0 0
/dev/mmcblk1p6 /boot vfat defaults 0 0

With this patch only valid entries should be added
/dev/mmcblk1p6 /boot vfat defaults 0 0

Signed-off-by: MarkusVolk <f_l_k@t-online.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 7aa678ce804c21dc1dc51b9be442671bc33c4041)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
scripts/lib/wic/plugins/imager/direct.py

index 7e1c1c03ab307fcd18aaeddca4be9d76638644d8..2505c13fce126578a95c22189085666c4b1b0a0c 100644 (file)
@@ -115,7 +115,7 @@ class DirectPlugin(ImagerPlugin):
         updated = False
         for part in self.parts:
             if not part.realnum or not part.mountpoint \
-               or part.mountpoint == "/":
+               or part.mountpoint == "/" or not part.mountpoint.startswith('/'):
                 continue
 
             if part.use_uuid: