]> code.ossystems Code Review - openembedded-core.git/commitdiff
image.bbclass: Sorted ctypes to avoid basehash error
authorGerson Fernando Budke <nandojve@gmail.com>
Fri, 22 Sep 2017 05:29:08 +0000 (07:29 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 22 Sep 2017 16:52:58 +0000 (17:52 +0100)
When selected multiple subimages a similar error could happend:
  Variable do_image_cpio[subimages] value changed \
    from 'cpio.gz.u-boot cpio.gz' to 'cpio.gz cpio.gz.u-boot'
To avoid this, 'ctypes' should be sorted at 'gen_conversion_cmds'.

This garantee that 'CONVERSION_CMD_xxx' are always written in tha same
order and consequently 'do_image_cpio' have the same hash.

(From OE-Core rev: 271f1a5f65b8685a1e3645026876251122ef3974)

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image.bbclass

index ef2b38aeafa96e71840e0618f6d4f72252cc20ad..9c9f14a99a4c6b050bbe2a025703706215ccd374 100644 (file)
@@ -453,7 +453,7 @@ python () {
 
         rm_tmp_images = set()
         def gen_conversion_cmds(bt):
-            for ctype in ctypes:
+            for ctype in sorted(ctypes):
                 if bt.endswith("." + ctype):
                     type = bt[0:-len(ctype) - 1]
                     if type.startswith("debugfs_"):