]> code.ossystems Code Review - openembedded-core.git/commitdiff
image_types: Fix ubi filesystem return codes
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 3 Jun 2014 12:51:24 +0000 (12:51 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 10 Jun 2014 16:10:34 +0000 (17:10 +0100)
If the first command returns an error, it will not cause the image generation
step to fail. Simply split up the statement into multiple lines to avoid
this issue, they no longer need to be one line expressions.

[YOCTO #6391]

(From OE-Core rev: f8125a1e9b6893a12355d55d4df584a8d97f0bff)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image_types.bbclass

index f38e3b6a11d90680d364116ac532662a57cf4eef..99a07da0fc11bc9d83558c76026820e3ac8df112 100644 (file)
@@ -93,7 +93,8 @@ IMAGE_CMD_ubi () {
        echo vol_type=dynamic >> ubinize.cfg 
        echo vol_name=${UBI_VOLNAME} >> ubinize.cfg 
        echo vol_flags=autoresize >> ubinize.cfg
-       mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS} && ubinize -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubi ${UBINIZE_ARGS} ubinize.cfg
+       mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS}
+       ubinize -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubi ${UBINIZE_ARGS} ubinize.cfg
 }
 IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS}"