]> code.ossystems Code Review - openembedded-core.git/commitdiff
qemurunner: Ensure logging handler is removed
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 7 Nov 2017 23:23:54 +0000 (23:23 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 9 Nov 2017 11:49:13 +0000 (11:49 +0000)
If we don't remove the handler we end up with duplicate log messages
which is undesireable.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/utils/qemurunner.py

index 72f05d597f6e22897a40d1680ab0e2431fc97751..aa2600b827073edd42c9b62d84c93c76213cbf4f 100644 (file)
@@ -58,7 +58,8 @@ class QemuRunner:
         self.host_dumper = HostDumper(dump_host_cmds, dump_dir)
 
         self.logger = logging.getLogger("BitBake.QemuRunner")
-        self.logger.addHandler(logging.StreamHandler(sys.stdout))
+        self.handler = logging.StreamHandler(sys.stdout)
+        self.logger.addHandler(self.handler)
 
     def create_socket(self):
         try:
@@ -370,6 +371,7 @@ class QemuRunner:
         self.ip = None
         if os.path.exists(self.qemu_pidfile):
             os.remove(self.qemu_pidfile)
+        self.logger.removeHandler(self.handler)
 
     def stop_qemu_system(self):
         if self.qemupid: